Support Forum

Please note that this forum is only available to you in read only mode. In order to contribute to this conversation you will need to renew your subscription.

'belowcontent' Position Doesn't Have zen-row & zen-spotlight Wrapping Divs Within, Like Other Positi

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Hi,

The issue is as described above - working on local site so no link available. You guys will need to investigate further (as I don't believe this is how it's supposed to be because without those wrapping divs within it, like all other positions, then the margins & padding settings don't work for the position).


z-jb-belowcontentpositiondoesnthavethezen-rowspotlightcontainerswithintheposition-unlineallotherpositions.png

I attached this image but I don't think it's necessary as you should be able to see it on your own installations too.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

Where abouts are the modules in the layout?

As you can drag and drop them they can turn up in odd places

Can you confirm they are above and below content as their respective names indicate?
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

Sure, yes, I put 1 module in the belowcontent position.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

looking at the front end of the demo site via a quickstart I can't see a problem with the abovecontent or belowcontent

I'm looking at the allpositions layout in buildr and koan style
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Are you seeing differences between these positions and the main content?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

If you compare all the wrapping divs within the abovecontent & belowcontent id tags, then you should see that they're different.
belowcontent doesn't have all the same wrapping divs within it & so it's not taking the margin/padding settings (like above content & other rows as well as container positions do).

I'm using the base4 theme with the following module layout:

z-currentmodulelayout.png


If you compare the following abovecontent and belowcontent rows/module positions...you should be able to see the difference.

abovecontent:

z-jb-abovecontent-correctstructure.png


belowcontent (not enough wrapping tags within it - I tried to append the same container-padding as abovecontent but it doesn't take the setting):

z-jb-belowcontent-incorrectstructure.png


Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
Last Edit: 7 years 4 months ago by Aadil.
The administrator has disabled public write access.
On abovecontent I'm seeing it applying on the zen-spotlight

.container-padding .zen-spotlight {
padding: 30px 4%;
}
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
But belowcontent does seem to have an issue

I'll need to check with the developers to confirm

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
With belowcontent it does look like a bug

Thanks for the spot

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Aadil,

We had a chat about the position and its a slight grey area with the container and the position - it isn't a bug as such

The container option for this row should in an ideal world not be there but given it would require complicated coding to remove it, the container was left in as an option for the row

The adding of the container would be problematic from a nesting point of view so was left out for this row/position - particularly we think for bootstrap

It isn't a position people use so it's not cropped up before

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

I don't fully understand what you mean?

The reason that leads me to think it's a bug is because the abovecontent module position (in the abovecontent row) has all the 'proper' divs nested within the row & container...and the abovecontent row/module-position is nested in the same way as the belowcontent row (I think it's only the belowcontent row that's visible, with no containers within it).

Basically, both abovecontent and belowcontent are within the main area...so shouldn't they both have the same div structure (...the issue is that now I can't use any margin/padding on this row/position from within the template admin...which is what I'd want to do, for consistency sake)?

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
...I wouldn't think (not completely sure here) that it'd be difficult to include the missing divs/ids for belowcontent...as shouldn't that only involve a similar process to overriding joomla component/module views via the Joomla Template Manager.

Then, to avoid conflict for existing installations (when you release an update), you'd turn off all the row/container margin/padding settings for belowcontent by default...or would it be more complicated than this?
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
I will talk to the developers again tomorrow about this

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
The following user(s) said Thank You: Aadil
[Post moved to correct thread topic]
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
Last Edit: 7 years 3 months ago by Aadil.
The administrator has disabled public write access.
This issue is on the tracker

Is this issue a problem on a site in development?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Not right now but that's because I've been postponing tasks while waiting on fixes.
I still have other things I can do in the mean time so this is not critical right now but I would hope for it to be fixed soon.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
thanks

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Happy Campers