Support Forum

Please note that this forum is only available to you in read only mode. In order to contribute to this conversation you will need to renew your subscription.

search / logo issues buildr

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

No problem Paul. While we're on the topic of row/module position bugs...I think there's also an issue with the logo row.
I have 2 module positions in it (logo as well as the search position).

For some reason, modules with only an image in it, don't append the moduletable margin correctly (in my case, each module is supposed to have a bottom margin but as you'll see, the bottom margin doesn't get appended to the end of the module...for some reason, it starts at the top of modules in this row):

z-jb-logorow-moduleswithonlyanimagedontgetmoduletablemargincorrectly.png


Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

I've moved this to a new thread
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
With the module highlighted is there any content in it?

Is it the facebook image?

Looking at the screenshot it can just the margin that is displaying

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

Sure. Yes, only the facebook image is in that moduletable (module) - and as you can see, the bottom-margin doesn't get applied after the image.

Then in the module below it (the 2 lines of text you see), are 2 paragraphs (this module doesn't have a bottom margin because I custom coded the removal of bottom margins from last-child modules).

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi,

I found out that the reason the bottom-margin isn't getting applied is because I need to insert a div below any floated elements, to "clear:both;".

It's a know quirk about floated elements within parent wrappers.

I guess now I'll need to find a way to programatically insert the clear property after all elements within a module/component.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
ah floats

I've not tried this myself with a jb site but option 3.

www.sitepoint.com/clearing-floats-overview-different-clearfix-methods/
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Method 3: The “clearfix” Class
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Yeah, I also hadn't used the clearfix before because I don't think I needed to...but it is very useful.

I remember seeing the .clearfix class being defined in builder (also, saw it when I inspected your demo templates...can't remember which) - so will use the existing buildr .clearfix class to sort this out.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Yes it is used in buildr and other framework versions - I just keep forgetting and using the old school way with a clear class :)

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Happy Campers