Support Forum

Please note that this forum is only available to you in read only mode. In order to contribute to this conversation you will need to renew your subscription.

Image Class Media Queries Remove Side Margins in Buildr

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Hi,

I've started attempting to format my content on each page more correctly...so I've also begun using image classes for any images I include in my article.

However, I find that the .image-left & .image-right classes remove the side margins when the browser is shrunk - is this a mistake because now the content sticks to the side of the image?

z-NEEDTOEDITTHEMEDIAQUERIES-forImages.png


I haven't looked at all your class implementations yet but maybe you guys might want to revisit all the image classes again, if possible?

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
Last Edit: 7 years 5 months ago by Aadil.
The administrator has disabled public write access.
Hi Aadil,

Is this site live?

cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

This is a local wamp site...have been working on it to iron out all the bugs (as it will need to replace a previous jb t3 template - base3 I believe).

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Ok but is the version the latest buildr version?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Yes, it's 1.3.2

Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Which pre-set are you using?

Is it koan?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Do you also get the same if you use the floatleft and floatright

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Nope, it's Base4 - all threads I've opened are associated with this Base4 Buildr installation.

Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
I just tried floatleft via the browser inspect tool, by editing the class via the browser, and that does seem to work.

Those seem like the classes to use, thanks!...however, what would the img-left and img-right classes be used for then (if not for images in the content)?

Aadil


Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

Do you have an example of img-left or img-right on a demo site?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Sure Paul but it's on my local installation - the screenshot above is of this class in action.

Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
I didn't think we used this class on a demo site other than T3

Have you seen this on a joomla Bamboo zgfv4/5 demo site?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
I've only used 3 or 4 templates in total from you guys this far and in my local Buildr installation, I've only noticed this class now (now that I'm attempting to structure the content properly).

The class came up in the JCE editor in the list of classes...so I thought it was the correct class to apply to images.

I haven't looked at the code in any other template so I haven't actually noticed this class anywhere else.

Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
There are some classes that are available but we don't use

I'll have a closer look in the morning

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
The following user(s) said Thank You: Aadil
Hi Paul,

I implemented the 'floatleft' class via the actual article now. It seems that the margin values on the sides are percentage based and hard-coded at 3% (which isn't ideal when, for example, you have a list next to an image) - are there any other classes that might be better to use for images?

The floatleft class in context:

z-18s30hsore09kd03kg93lt-03i5.png


The list is too close to the image in this shot:

z-223hf93i9r10re323-sf.png


Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

There isn't any class in the code - having a list next to an image can be a problem and would depend on the list element used e.g. ol, ul or dl

You could try adding overflow or list-style-position: inside; on the tag

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Thanks Paul,

I'll have a go at implementing those and see how it turns out.

The thing with using these classes, to format article content better, is that I don't really know how many classes there are to use - could you guys maybe look at adding these classes to your docs (or the blankly theme) so there's some reference point in future?

For example, I don't think the .divider class is listed anywhere (I happen to see you guys using it on your demo pages though) and also, I don't think the image classes are available anywhere.

I'm not sure if I missed others yet.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

Yes I think this is a good idea - we do have a lot to fix and update but I definitely think this is something we should look at doing

We could add to blankly and to a docs page

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
The following user(s) said Thank You: Aadil

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Happy Campers