Hi all,

I'm currently in the process of customising the Responsive template.
I use two framework overrides (openContainer.php combined with closeContainer.php) to embed an additional class within the stock template's .fullWrap class.

Everything is working as I expected.

However today I decided to experiment with the framework's new "Toggle Menu" feature for mobile devices. This worked beautifully and as expected on a stock install of the Responsive template, but failed to render on my working installation. At first I assumed it was a custom CSS issue but ruled this out when I removed my custom CSS file from the equation.

I then deactivated my custom overrides and the Toggle Menu appeared and functioned as expected. The upshot is that (for the moment) I cannot use the Toggle Menu functionality alongside open/closeContainer.php overrides. I'm currently looking at additional/alternative solutions but I'm curious as to whether this is expected behaviour (if so it would appear to render open/closeContainer overrides useless if Toggle Menu is required) or is it an unexpected bug?

Just to reiterate, I have tested the overrides on an unmodified (stock) Responsive template with the same results. All I am adding to the overrides is an additional div.

Admittedly it's late here (3:20GMT) and this is hopefully something obvious and stupid that I am overlooking.

EDIT : Dropping unmodified open/closeContainer.php framework overrides into the stock template produces the same result. Toggle Menu refuses to render (and additional/associated code does not appear within source) when open/closeContainer override files are present and enabled within the Responsive template.

Thanks & kind regards

John

Hey John,

Yes I discovered this yesterday actually.

Ive attached the fixed override here.

Thanks for spotting it.

dl.dropbox.com/u/908346/openContainer.php.zip

Anthony

Hi Anthony,

Thanks for the quick fix. Works a treat.

(I presume this will make it's way into a future update of the framework?)

Thanks again for the quick assistance, it's very much appreciated.

John

Sure no probs

Likely to be in a release this week.

Brilliant.

Thanks again Anthony.

John

Sure thing

Hi again Anthony.

Not sure if it's something I'm doing wrong but I've just noticed a little quirk with the new openContainer override you supplied.

If I replace the old file within the framework with the new one you supplied the Toggle Menu works as expected.

However, when I place the new file within the actual template and enable the appropriate override it now results in a blank frontend.

I have tested this on my own site and on a stock install of Responsive, both show the same result. When I switch back to either my own custom override or the current stock framework override the frontend reappears. Just for the record, I have not made any modifications to the file you provided.

Thanks again.

John

Seems like a php error perhaps.

Can you enable error reporting so we can see whats happening?

Hi Anthony,
No problem. I've just enabled error reporting (and really should have thought of that before I posted).

I get the following error:
Parse error: syntax error, unexpected $end in /Applications/MAMP/htdocs/dev/templates/jbresponsive/layout/openContainer.php on line 29

This is from a local install, though I get the same Parse error (different file path) when testing on remote server.

Thanks again
John

EDIT: Had a look at the override over coffee and removing the single parentheses on line 20 appears to fix the issue (see screenshot).

However, I'd be happier if you could confirm.

Awesome thanks for confirming - coffee is a wonderful thing

No problem - and you're right about coffee.