OK bit of an odd one on my site (thumped.com)

I've site-wrap ads (you know - a sidebar on each side of the content) from an ad agency running on my site that display fine, but the links don't work when I've any ZGF based template running. Or rather, the links work for a fraction of a second before the page finishes loading.

- I've verified this behaviour on Newstream (my live template) & Newscyle

- I've tested on a page with every module disabled and the links still don't work

- I've disabled & reenabled plugins

- I've tried different jquery libraries

- If I switch back to an old Rockettheme template I used to use the links immediately start working.

Any ideas? The ad agency are giving me grief over the lack of links, understandably enough...

Hi there,

I am not so sure it is the template, as I can't see the banners in either Milkyway, Beez or JA Purity; I think it is probably a combination of how they have been inserted and some script errors. Your site is throwing a lot of errors like this:

obj.addEventListener is not a function
thumped.com/plugins/system/mfblank/mfblank.js
Line 24

Those errors also exist when I view your site with Milkyway, Beez or JA Purity. I think you need to investigate and resolve that script error first off.

You probably couldn't see the banners in Milkyway, Beez or JA Purity because the javascript invocation code wasn't added to those templates' index HTML.

I temporarily switched the code to a module published to 'right' position, which made it show up in a few more templates. It was in Beez (and working) Milkyway (working), Mixxmag (working), purity (not working, but not really all that surprising considering the state of the page...).

It's now running published to footer, but not all templates have this position so obviously it won't show up on them all.


I'm not sure where you're seeing that .js error, but I've disabled the mfblank plugin for now.

Hi there,

Looks like k2.js is causing the issue now.

ReferenceError: Can't find variable: SmoothScroll in k2.js.

Which links aren't working on the site? Ive checked a few and they seem ok.

Anthony

i'll look into that k2.js error

the sidebar / wrap ads are booze related and so because of our advertising regulations will only appear between midday & midnight (i think) Irish time.

pete wrote:
like now

Hey Pete,

I can still click on the ads - are they live now?

Anthony

no, they're midday to midnight Dublin / London time only

unclickable sidebar / wrap ads up now

right so

After many hours poking at firebug I discovered that if i edit template_css.css in /templates/zengridframework/css and change


.outerWrapper,.fullWrap {float: left;width: 100%;display: inline}

to

.outerWrapper,.fullWrap {width: 100%;display: inline}

it starts working.

Weird.

The question now is will this break anything?

edit: test page up at thumped.com/media/test-page.html

Hey there,

Yes that is a little weird. What you can do is just add that to the top of the css/theme.css file and it will not get overwritten when you update the zen grid framework itself.

Thanks for finding the answer too We were at the mercy of the time zone difference and I wasn't able to look at it when the ads were active.

Anthony

turns out they're still unclickable on the site homepage - so i'm guessing it's a mod_slideshow3 or mod_microblog CSS conflict now, since they're the only 2 modules on that page that aren't used on the rest of the site.

But that's for another day.

No probs - can you ping us back when they are online again?

Anthony

ok they're live again now.

turns out after a bit more testing that the homepage sidebar / wrap ads are clickable in IE9, but not FF6 or Chrome 14.

RIGHT

so removing

<div class="clear"></div>

immediately after the <!-- Full Wrap --> in /templates/zengridframework/index.php fixes the problem. no idea why.

just what would we do without firebug?

pete wrote:
I've put that float:left back in and everything is still working, so it definitely looks like the clear div is the actual culprit. Times like these i wish i actually understood CSS.

tested in IE9, FF6, Chrome 14

Yeah thats odd.

Sounds like a validation issue actually. e.g. a missing closing div perhaps?

Since that clearing rule should just clear the lot.

Ill take a look tonight my time when it comes back online again.

Do you mind pinging me again when the ads are up?

Anthony

Anthony Olsen wrote:
bump

Hi Pete,

I think Anthony is right, you need to try and work out these markup errors:

validator.w3.org/check?uri=http%3A%2F%2Fthumped.com%2Fmedia%2Ftest-page.html&charset=%28detect+automatically%29&doctype=Inline&ss=1&group=0&user-agent=W3C_Validator%2F1.2

In particular, I see that you have unclosed img tags on some of the ads. That could well be the cause of your issues. You need to get those resolved.

i'm inclined to agree with you. i reinstated that clearing div i took out, but put a single extra </div> before it - problem goes away. so obviously *something* isn't right in one of the modules / external ads.