Support Forum

Please note that this forum is only available to you in read only mode. In order to contribute to this conversation you will need to renew your subscription.

Pinterest slows the module even if pinterest has been disabled (bug?)?

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

8 years 9 months ago
I've been working with Responsive2 and Zentools 2 and was attacking the page speed (both pagespeed and yslow) which hit me hard on Pinterest being loaded. I noticed Zentools2 is loading Pinterest script regardless of whether Pinterest has been added to the module settings (slows the site on gzip and a host of other reasons). After commenting out a little php my score went up 3% in the right direction (got to 98% on both yslow and pagespeed so far!). I just wanted to confirm if this is a bug and if there are any consequences to the following changes (or a better approach) and I did the right thing!:

file: modules/mod_zentools2/tmpl/blocks/pinterest.php
<?php
/**
 * @package		Zen Tools
 * @subpackage	Zen Tools
 * @author		Joomla Bamboo - [email protected]
 * @copyright 	Copyright (c) 2013 Joomla Bamboo. All rights reserved.
 * @license		GNU General Public License version 2 or later
 * @version		1.8.5
 */

defined('_JEXEC') or die('Restricted access'); 

// Get the doc
$doc = JFactory::getDocument();
$doc->addScript("//assets.pinterest.com/js/pinit.js"); ?>

I changed the code to comment out the whole function within the php:
<?php
/**
 * @package		Zen Tools
 * @subpackage	Zen Tools
 * @author		Joomla Bamboo - [email protected]
 * @copyright 	Copyright (c) 2013 Joomla Bamboo. All rights reserved.
 * @license		GNU General Public License version 2 or later
 * @version		1.8.5
 

defined('_JEXEC') or die('Restricted access'); 

// Get the doc
$doc = JFactory::getDocument();
$doc->addScript("//assets.pinterest.com/js/pinit.js");*/ ?>

Loving Zentools2 :) !
Jaimie
  • Jaimie's Avatar
  • Jaimie
  • LIfetime Developer - Big Bamboo
  • 6 posts
  • 1 Thanks
  • Karma: 0
The administrator has disabled public write access.
8 years 9 months ago
Hi Jaime,

I've asked a developer to take a look

thanks
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
The following user(s) said Thank You: Jaimie
8 years 9 months ago
Hi Jaimie,
Glad you like Zentools2 and thanks for pointing the issue out.

Ive just fixed this locally and it will be added to the next update.

Also they are some nice site scores :)
  • Anthony Olsen's Avatar
  • Anthony Olsen
  • LIfetime Developer - Big Bamboo
  • 23925 posts
  • 788 Thanks
  • Karma: 433
The administrator has disabled public write access.
The following user(s) said Thank You: Jaimie
8 years 9 months ago
Thank you Anthony and Paul,

It's worked very well and have since got the speed up to 99/99 (pagespeed/yslow). Will keep an eye out for the next release.

Kind Regards,
Jaimie
  • Jaimie's Avatar
  • Jaimie
  • LIfetime Developer - Big Bamboo
  • 6 posts
  • 1 Thanks
  • Karma: 0
The administrator has disabled public write access.
8 years 9 months ago
You're welcome :)

I'll update when we release the update

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Happy Campers

Close