Support Forum

Please note that this forum is only available to you in read only mode. In order to contribute to this conversation you will need to renew your subscription.

.zen-below & .zen-above Class Properties Need To Be Swapped

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Hi,

I spotted that these two framework classes have the properties mixed up - they need to be swapped. Using Buildr 1.3.2 without any of the new standalone child templates.

z-jb-marginpropertiesforzen-belowzen-abovemustbeswapped1.png



z-jb-marginpropertiesforzen-belowzen-abovemustbeswapped2.png



Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

These seem correct to me - do you have an example where it's not looking right?

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

If you looked at the 2 screenshots I posted then I believe you'd be able to see they're mixed up - I even highlighted the code.

Regards,
Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Yes I looked at the code example

The code looks correct and my local version also

If you have a live example then I can see what I am missing

Thanks
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

In the 2nd screenshot, which is what I got when inspecting the template in the browser, the .zen-below class has a margin-top property - but the Blankly listed class (1st screenshot) states that the margin-bottom property should be applied.

Aadil
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
Hi Aadil,

I'm sorry but I don't understand what the issue is and I can't see it locally

If its above I'd expect a bottom margin and for below I'd expect a margin top

If you can point me to a live example that might help understand what the issue is

Thanks
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
Hi Paul,

It's conflicting information - I think the 1st screenshot, of the Blankly listed scaffolding class .zen-below, needs its property info (that's listed on the scaffolding page) changed from margin-bottom to margin-top.
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
oh right ok

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.
....if you look at .zen-below in each screenshot, then you should be able to see that they have different properties - so that means in 1 of the shots, it's wrong.
  • Aadil's Avatar
  • Aadil
  • LIfetime Developer - Big Bamboo
  • 292 posts
  • 13 Thanks
  • Karma: 4
The administrator has disabled public write access.
thanks will look at this tomorrow

Cheers
Paul
  • manh's Avatar
  • manh
  • Moderator
  • 45248 posts
  • 2106 Thanks
  • Karma: 603
The administrator has disabled public write access.

zentoolsIf you use Zentools please post a review at the Joomla! Extensions Directory.

Happy Campers