Hi,

In a module, when I insert a Header Class then other classes are also inserted too - at a minimum, I believe duplicate 'zen-module-title' class needs to be removed from the header tag.
The side-effect of the above is that the bottom-margin of the header tag is affected (it gets reduced when this shouldn't happen).

This is how the spacing looks without any Header Classes applied to the module



Then when I insert the class here...



...the bottom margin is reduced for the module header-tag - this is because of the duplicate 'zen-module-title' class.



Regards,
Aadil

Hi Aadil,

Do you mean the header class in the advanced tab?

Do you get the same with adding icons in the module title

Cheers
Paul

Hi Paul,

"Do you mean the header class in the advanced tab?"
Yes. I took screenshots of this, above.

I haven't tried icons - only a class.

Regards,
Aadil

I don't think we considered the Header class in any override in any template

There may be a glitch with module titles somewhere but with header classes I'm not sure how many people use them as I can't remember anybody asking this before

Cheers
Paul

I remember finding a bug before where classes were being duplicated but that was affecting sections or something (not headers).

As I've talked before, I've been testing while building/fixing things in Buildr as I don't want to commit to developing on it when there are bugs (because then I'll have to deal with those issues in future when I'm more time-limited).

I've provided login details in my ticket - you guys may have a look.

Regards,
Aadil

If its the module header class we don't support it as far as I'm aware so not a bug as such

It would need a new override in all the templates I think - I'll check on Monday

I think there is an issue with a double margin on the tracker in some situations

Cheers
Paul

Yes, the class only gets duplicated when I use the Header Class in a module.

The output would need to be changed (overriden, like you said) & I don't want to touch the official files because they'll get overwritten by your updates.

Hope you guys can take a look at this one soon.

Regards,
Aadil

Hi Aadil,

Can you try using the attached file to replace the one in the templates html folder.
It should fix the issue.

Regards,

Rob

Hi Rob,

Thanks for the fix - I'll try in the morning.
To make sure - am I only supposed to replace 1 modules.php file, in the location you mentioned above (and not the 2nd one located in the zengrid > html folder)?

Also, is this fix going to be part of an update at some point?
I know I also have another fix or two that sort out the js/ajax mapper in the plugin...so I'm having to manually apply the fixes each time.

Regards,
Aadil

It only needs to replace the templates/buildr/html/modules.php file.

I have just added the fix for testing and the next release.

Regards,

Rob

Hi Rob,

I pasted the fix into 3 local installs and on one site, I noticed that an 'S' is being outputted in my menu - I believe I found the line of code causing it in the modules.php but I don't 100% know what to remove (without breaking anything)...







Regards,
Aadil

...Please let me know about a new fix as soon as you can.

Regards,
Aadil

Hi Aadil,

Please just remove that S.

I'm not sure how that got in there.

Rob